[MEX-527] Bulk get methods #1535
Conversation
- bulk get methods for various fields - update 'feesUSD' compute method signature to enable creating a dataloader for the field; update cache warmer + setter services; update usage in router service - fix unit tests
| (tokenID) => tokenID === lpTokenID, | ||
| ); | ||
|
|
||
| if (farmAddressIndex === -1) { |
There was a problem hiding this comment.
here you used:
if index === -1 { return undefined } else { return from array }
and in the function below you used:
return index === -1 { return undefined } else { return from array }
maybe keep consistency and choose a single way
| return await getAllKeys<string>( | ||
| this.cachingService, | ||
| stakingProxyAddresses, | ||
| 'stakeProxy.stakingFarmAddress', |
There was a problem hiding this comment.
i would recommend putting all the keys in a cache.info.ts because:
- we can easily see all the caching keys in a single place
- we can easily reuse the keys somewhere else
- it helps the overall code by avoiding magic strings in the code
| }) | ||
| async feesUSD(pairAddress: string, time: string): Promise<string> { | ||
| return await this.computeFeesUSD(pairAddress, time); | ||
| async feesUSD(pairAddress: string): Promise<string> { |
There was a problem hiding this comment.
You need to update the IPairComputeService interface
| return addresses[farmAddressIndex]; | ||
| } | ||
|
|
||
| async getAllPairsFarmAddress(pairAddresses: string[]): Promise<string[]> { |
There was a problem hiding this comment.
I think we can remove some duplicated code. We have two methods that does almost the same thing: computeHasFarms and getPairFarmAddress. We can use the second method to determine if a pair has a farm
| return addresses[farmAddressIndex]; | ||
| } | ||
|
|
||
| async getAllPairsFarmAddress(pairAddresses: string[]): Promise<string[]> { |
There was a problem hiding this comment.
I think we can remove the methods that find a farm address for a single pair address. We can use this bulk methods with a single element in the array and we would have the same output
| }); | ||
| } | ||
|
|
||
| private calculateBoostedApr( |
There was a problem hiding this comment.
rename into computeBoostedApr
| return boostedAPR.toFixed(); | ||
| } | ||
|
|
||
| private calculateMaxBoostedApr( |
There was a problem hiding this comment.
rename into computeMaxBoostedApr
| return true; | ||
| } | ||
|
|
||
| async getAllBaseAndMaxBoostedAPRs( |
There was a problem hiding this comment.
I would use the existing compute methods for base and boosted APR: computeBoostedAPR computeMaxBoostedApr
- update Pair compute service interface and mock - remove duplicate logic for computing pair farms
Reasoning
Proposed Changes
getAllKeysutil function) for various fields of pairs, farms, staking farmsHow to test