Allow reading logs from local disk; add more metrics#5
Open
apurvis wants to merge 20 commits intomtrdesign:masterfrom
Open
Allow reading logs from local disk; add more metrics#5apurvis wants to merge 20 commits intomtrdesign:masterfrom
apurvis wants to merge 20 commits intomtrdesign:masterfrom
Conversation
* Read from local logs * README * clean up * clean up * README * parsing * even more working * working * workgin * Parse dates * better * operations info * simpler unique dates * simpler unique dates * simpler unique dates * refactor * warnings * stable * stable * var rename * variable names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #4 i'm unsure of how to run the specs to make sure this is a working PR that doesn't break stuff... but it does add features. If this project is still alive I can do whatever work is needed to bring this up to snuff. If it's not still alive, maybe someone will find these features useful.
Changes:
totaltimeof requests per objectGETrequestsGETexclude_lines_with_substringconfig optionThere's also one maybe not so good change, which is that all the logs (not just
GETs) are collated to memory in one giant list before statistics are computed. For my use case that was totally fine but for a situation with a ton of logs in S3 this is probably (definitely?) not a good thing as the script will probably run out of memory...