fix: use equals() instead of == to compare Method instances#84
Open
vpa1977 wants to merge 1 commit intomstrobel:developfrom
Open
fix: use equals() instead of == to compare Method instances#84vpa1977 wants to merge 1 commit intomstrobel:developfrom
vpa1977 wants to merge 1 commit intomstrobel:developfrom
Conversation
Building procyon with Java 25 results in the following failure:
com.strobel.reflection.SignatureTests > testSignatureOfGenericMethodInGenericDefinition FAILED
org.junit.ComparisonFailure: expected:<[<T:Ljava/lang/Object;>]([TT;)[TT;> but was:<[]([TT;)[TT;>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at com.strobel.reflection.SignatureTests.testSignatureOfGenericMethodInGenericDefinition(SignatureTests.java:71)
This is caused by == used instead of equals() to compare Method instances.
java.lang.reflect does not guarantee that Method instances are singletons.
vpa1977
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building procyon with Java 25 results in the following failure:
com.strobel.reflection.SignatureTests > testSignatureOfGenericMethodInGenericDefinition FAILED
org.junit.ComparisonFailure: expected:<<T:Ljava/lang/Object;>[TT;> but was:<[TT;>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at com.strobel.reflection.SignatureTests.testSignatureOfGenericMethodInGenericDefinition(SignatureTests.java:71)
This is caused by == used instead of equals() to compare Method instances. java.lang.reflect does not guarantee that Method instances are singletons.