-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/add scenario to climate #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…and update the availability of the air conditioner.
…ng API changes, service handlers, and sensor definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds scenario mode functionality to the ComfoClime integration, enabling users to activate special operating modes (cooking, party, holiday, boost) through the climate entity. The implementation includes new sensors for tracking active scenarios, API extensions for scenario control, a custom service handler, and comprehensive documentation.
Key Changes
- Adds scenario mode support with four preset options: cooking, party, holiday (away), and boost
- Introduces new sensors for tracking scenario time remaining and active scenario
- Extends the API with scenario-related parameters (scenario, scenarioTimeLeft, scenarioStartDelay)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| custom_components/comfoclime/translations/en.json | Reformatted JSON with consistent indentation; added translations for new scenario sensors and "none" (manual) preset mode |
| custom_components/comfoclime/translations/de.json | Reformatted JSON with consistent indentation matching English file |
| custom_components/comfoclime/entities/sensor_definitions.py | Added two new sensor definitions for scenario tracking: scenario_time_left and scenario |
| custom_components/comfoclime/comfoclime_api.py | Extended update_dashboard API method with three new optional parameters for scenario control |
| custom_components/comfoclime/climate.py | Added scenario mode constants, mappings, and formatted time display in extra_state_attributes |
| custom_components/comfoclime/init.py | Implemented new service handler for set_scenario_mode with validation logic |
| SCENARIO_MODES.md | Added comprehensive German documentation covering usage, examples, and troubleshooting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…automation examples, adjust timestamp format, and improve the translations for scenario modes in German and English.
…nt the function for setting scenario modes and update the associated service definitions in services.yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thank you very much. I will take a look and do some testing. Current main goal for the integration is stability, as I don't want any breaking updates in the future. But as this PR isn't modifying the python API very much I think we can consider integrating the function. |
… and update the assignment in the climate control.
|
Changing tables like the scenario timetable is currently discussed very much in the HA core forums. The amount of times to be set is not a very large number, so we could just integrate them as number entity. The holiday function in days, the rest in minutes. |
Hi @msfuture,
I've taken the time to add the scenario functionality here. It should work just like in the app. The next step would be to make the times adjustable somewhere. We can certainly discuss where that might be.
The two translations should be correct, I only adjusted the formatting. That's why there were so many changes.