Open
Conversation
…since neo4j 3.5.2)
dominique-vassard
force-pushed
the
bolt_v3
branch
from
ef09149 to
f3ef601
Compare
dominique-vassard
force-pushed
the
bolt_v3
branch
from
f3ef601 to
347d700
Compare
Contributor
Author
|
Finally everything is green :) |
Owner
|
So sorry for dropping the ball here, is this good to merge? |
mschae
reviewed
Mar 18, 2019
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## v 0.6.0 | |||
Owner
There was a problem hiding this comment.
I think this merits a new major version.
| # ] | ||
|
|
||
| # Supervisor.init(children, strategy: :one_for_one) | ||
| # end |
Owner
There was a problem hiding this comment.
Let's delete everything that's commented out.
| def set(version) do | ||
| Agent.update(__MODULE__, fn _ -> version end) | ||
| end | ||
| end |
Owner
There was a problem hiding this comment.
I'm not 100% but if I have a project and I connect to both v2 and v3 databases, wouldn't we still only have one instance of this agent and wouldn't it be confused?
I'd prefer introducing our own Connection struct that stores the connection (hence the PID of the tcp process) and the version used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mschae
I've implemented Bolt V3. (Issues #26)
I think though that a refactoring will be needed, the 3 versions and mixed in all files and it's hard to understand how a version is different from another. It relies on doc and on the fact that user knows what he's doing. Not really the best, and in fact the code is not self explanatory anymore.
Before tackling this issue, I wait to know what's going on with the bolt_sips - boltex separation: 2 projects or 1?
Thank you