feat: Modular Transform Pipeline#72
Open
thomas-coldwell wants to merge 4 commits intomrousavy:mainfrom
Open
Conversation
thomas-coldwell
changed the title
Contributor
|
Does this PR include Preserve Aspect Ratio Option on Android? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
resizemethod exported by the plugin in favour of atransformmethod which instead takes a series of transform operations that can be ordered in whatever way by the user to transform the Frame.This allows for a more flexible configuration and extensibility as each transform now operates on the buffer individually so any new operations can be inserted easily and operations such as
rotatecan now be applied before or after ops likeresizeto allow transforms that were previously not possible.