fix: Rename initialize() to registerAllNatives() to be more aligned with fbjni#1225
Merged
fix: Rename initialize() to registerAllNatives() to be more aligned with fbjni#1225
initialize() to registerAllNatives() to be more aligned with fbjni#1225Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mrousavy
changed the title
initialize() to registerNatives() to be more aligned with fbjniinitialize() to registerAllNatives() to be more aligned with fbjni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires change for Nitro Modules:
JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM* vm, void*) { - return margelo::nitro::$$androidNamespace$$::initialize(vm); + return facebook::jni::initialize(vm, []() { + margelo::nitro::$$androidNamespace$$::registerAllNatives(); + }); }It is backwards compatible though.