Skip to content

Conversation

@wh0th3h3llam1
Copy link

  • Add AccessToken model
  • Create API for AccessToken
  • Add tests

applied changes from conversation in #170 ,

  1. only name can be updated from API.
  2. Kepst serializers to be reused in future APIs
  3. update tests

@wh0th3h3llam1 wh0th3h3llam1 requested a review from mrmn2 as a code owner November 18, 2025 01:52
@mrmn2
Copy link
Owner

mrmn2 commented Nov 18, 2025

Hi, glad to have you back. I thought I lost you because of my inactivity. As promised my break is over.

Since I thought you do not want to continue I did some research for taking over this issue. I now think that using the default DRF token authentication is sufficient for PdfDing, as every user will only have one token at a time. There is no real need for an extra dependency.

If you are annoyed by yet another change in requirements I can totally understand you and will merge your PR and change the authentication myself. Of course if you want to do it I am also happy. Just let me know which way you want to proceed.

@wh0th3h3llam1
Copy link
Author

@mrmn2

so based on what you're suggesting, user will have only one token (DRF token). but how will he generate the token? using UI only? if yes. then ig we wont need any extra model or serializers or these endpoints. also, there will only be option to create/delete token by default. if we wanna rotate, we might need custom logic

and no, i'm not annoyed by these changes. it totally fine.

@mrmn2
Copy link
Owner

mrmn2 commented Nov 19, 2025

Yes, users can only generate / rotate the token via the UI. I think this enough for this project. It will also make things simpler and thus easier to maintain. Many other popular self-hosted projects do it like this as well.

I am relieved to hear that you are not fed up!

@wh0th3h3llam1 wh0th3h3llam1 marked this pull request as draft November 25, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants