This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Added getSource(), fixed _getMasterStatus(), Constants cleanup#6
Open
markubiak wants to merge 4 commits intomrene:developfrom
Open
Added getSource(), fixed _getMasterStatus(), Constants cleanup#6markubiak wants to merge 4 commits intomrene:developfrom
markubiak wants to merge 4 commits intomrene:developfrom
Conversation
Author
|
I'm publishing my minidsp control module and would like this PR to be mainlined (and updated on npm) so that I don't have to create and maintain my own fork. Is there something I can fix in the PR? Mark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many things in this PR, if you want me to split them up let me know.