GLTFExporter: Fix skinIndex export for InterleavedBufferAttribute #32607
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
GLTFExporterwhereskinIndex(JOINTS_0) attributes were being exported incorrectly if they were stored as anInterleavedBufferAttribute.The issue can cause this exception:
When
skinIndexdata needed to be converted toUNSIGNED_SHORT(e.g. if the source wasUint32Array), the exporter was creating a newUint16Arraydirectly from the underlyingattribute.array.For
InterleavedBufferAttribute,attribute.arrayrefers to the entire shared buffer containing data for multiple attributes. This resulted in the exportedskinIndexaccessor containing mixed data from other interleaved attributes, ignoring the stride and offset.