Add support for mayas openPBRsurface shader when using the fbx-loader #32584
+51
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case 'Maya|baseColor': | ||
| parameters.map = scope.getTexture( textureMap, child.ID ); | ||
| if ( parameters.map !== undefined ) { | ||
| parameters.color = ColorManagement.colorSpaceToWorking( new Color("white") ) // MATERIAL COLOR GETS SET TO BLACK BY MAYA WHEN A COLOR MAP IS APPLIED, SO SETTING IT TO WHITE TO RESOLVE THAT PROBLEM |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
| case 'Maya|emissionColor': | ||
| parameters.emissiveMap = scope.getTexture( textureMap, child.ID ); | ||
| if ( parameters.emissiveMap !== undefined ) { | ||
| parameters.emissive = ColorManagement.colorSpaceToWorking( new Color("white") ) // MATERIAL COLOR GETS SET TO BLACK BY MAYA WHEN A COLOR MAP IS APPLIED, SO SETTING IT TO WHITE TO RESOLVE THAT PROBLEM |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fbx loader did not recognize maya's openPBRsurface shader, instead it defaulted to the phong material.
Changed so it gets converted to MeshStandardMaterial instead.
Also when parsing the image url's, paths that included "/" instead of "\" would not be parsed correctly. The parsing now use regex to account for that use case as well.
Found issue mentioning this: #15927