Skip to content

Payment Handler API (defer)#420

Open
marcoscaceres wants to merge 1 commit intomainfrom
handler
Open

Payment Handler API (defer)#420
marcoscaceres wants to merge 1 commit intomainfrom
handler

Conversation

@marcoscaceres
Copy link
Contributor

No description provided.

@annevk
Copy link
Contributor

annevk commented Aug 6, 2020

I thought that we only used defer if we decided not to look at something. From the description it seems like we looked at this quite a bit and therefore non-harmful seems more appropriate.

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#23 is closed, should this pull request instead be referring to #390? If so, that issue still needs a clear summary rationale in the issue itself which is then reflected here. If not, how do we close #390?

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to:

  • ✅ re-open #23
  • record the reasoning for a new position of "non-harmful" in that issue, and then
  • update this pull request accordingly, referencing 23 to re-close it.

@tantek tantek mentioned this pull request Sep 2, 2020
Base automatically changed from master to main January 15, 2021 11:27
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accurate update.

@zcorpan
Copy link
Member

zcorpan commented Apr 28, 2025

I've rebased this to match current conventions. But #23 has recent comments. I'll wait a bit with merging to avoid flip-flopping.

@zcorpan
Copy link
Member

zcorpan commented Oct 9, 2025

The comments above suggest neutral (previously called non-harmful), and #23 (comment) also seems neutral (mildly positive on mobile, mildly negative on desktop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants