Backport upstream changes to master #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The coremidi dependencies was updated to pick up a more recent non-released branch. This was done so that we don't need to vendor old versions of the core-foundation and core-foundation-sys crates * The wasm32 target was removed in order not to have to vendor all its dependencies (which would be unused)
We'll handle picking the right version on the gecko side.
This reduces the differences with upstream.
Cargo.toml updates
Upgrade to alsa 0.7
ibmibmibm
force-pushed
the
firefox-vendoring
branch
from
a01f839 to
d7ecd23
Compare
Previously, the ALSA backend created a new `Vec<pollfd>` and immediately called `Vec::set_len`. This exposes uninitialized `pollfd`s, which causes undefined behaviour. This commit fixes this by initializing the `Vec` with invalid, but still initialized, `pollfd`s before filling it. In addition, this commit simplifies the code slightly by removing the usage of `Vec::into_boxed_slice`. Fixes Boddlnagg#110.
- Replace memalloc crate dependency with rust std alloc/dealloc
ibmibmibm
force-pushed
the
firefox-vendoring
branch
from
d7ecd23 to
b5fd519
Compare
ErichDonGubler
force-pushed
the
firefox-vendoring
branch
2 times, most recently
from
c09092f to
0cc61b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.