Skip to content

chore: better testing for validate exit codes #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikewilli merged 1 commit into from
Jan 26, 2026
Merged

chore: better testing for validate exit codes #2977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion jetstream/tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,28 @@ def test_validate_private_example_config_no_dataset(self, runner, monkeypatch):
config.write(conf)

result = runner.invoke(cli.validate_config, ["my_cool_experiment.toml", "--is_private"])
assert result.exit_code
assert result.exit_code == 1
assert "dataset_id needs to be explicitly set for private experiments" in str(result)

def test_validate_invalid_toml_exit_code(self, runner, monkeypatch):
monkeypatch.setattr("jetstream.cli.ExperimentCollection.from_experimenter", cli_experiments)
with runner.isolated_filesystem():
conf = dedent(
"""
[experiment
start_date = "2020-12-31"
end_date = "2021-02-01"
start_date = "2020-12-31"
"""
)

with open("my_cool_experiment.toml", "w") as config:
config.write(conf)

result = runner.invoke(cli.validate_config, ["my_cool_experiment.toml"])
assert result.exit_code == 1
assert "TomlDecodeError" in str(result)

def test_validate_example_outcome_config(self, runner, monkeypatch):
monkeypatch.setattr("jetstream.cli.ExperimentCollection.from_experimenter", cli_experiments)
with runner.isolated_filesystem():
Expand Down