Skip to content

Conversation

@gleonard-m
Copy link
Contributor

Related to PR #474

  • fixing push to GAR error for ads_attribution_dap_collector

AE-956

This docker-etl job reads configuration from an ads owned bucket, collects DAP results and inserts into a BigQUery table. If the table does not exist the job creates it.

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is
    referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to
    .circleci/config.yml) will cause environment variables (particularly
    credentials) to be exposed in test logs
  • Ensure the container image will be using permissions granted to
    telemetry-airflow
    responsibly.

Note for deployments: In order to push images built by this PR, the user who merges the PR
must be in the telemetry Github team.
This is because deploys depend on the
data-eng-airflow-gcr CircleCI context.
See DENG-8850 for additional discussion.

@gleonard-m gleonard-m requested a review from a team as a code owner January 27, 2026 19:36
@gleonard-m gleonard-m requested a review from a team January 27, 2026 19:36
Copy link
Contributor

@mashalifshin mashalifshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gleonard-m gleonard-m merged commit 21354cb into main Jan 27, 2026
3 checks passed
@gleonard-m gleonard-m deleted the AE-956-attribution-build-fix branch January 27, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants