Abstract revision class #3145
Draft
Abstract revision class #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the change is related to Github revisions
vrigal
commented
Jan 16, 2026
Collaborator
Author
vrigal
left a comment
vrigal
left a comment
There was a problem hiding this comment.
I tried to keep this work concise.
I can work on the different points in separate PR to ease iterations.
| """ | ||
| Send an email to administrators | ||
| """ | ||
| if not isinstance(revision, PhabricatorRevision): |
Collaborator
Author
There was a problem hiding this comment.
We should support Lando publication from a generic revision (email reporter).
Collaborator
There was a problem hiding this comment.
Yes, but i'm not sure Lando supports github revisions on the warning endpoints yet
La0
requested changes
Jan 16, 2026
| """ | ||
| Send an email to administrators | ||
| """ | ||
| if not isinstance(revision, PhabricatorRevision): |
Collaborator
There was a problem hiding this comment.
Yes, but i'm not sure Lando supports github revisions on the warning endpoints yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3144
Base refactoring to support Github revisions.