-
Notifications
You must be signed in to change notification settings - Fork 13
[Unitary hack] Make a function that takes a circuit as an input and mixes it with the QPIXL input. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello @danielbultrini, May you check the pr please. |
|
Hi, thank you very much for this submission, I will check it soon! |
|
Hello @danielbultrini, May you check the pr please. |
|
I have checked this now, and it is good - tomorrow is the last day of the hackathon, so we will decide on the best implementation then. Thank you for the submission (sorry I was on vacation until today). |
@danielbultrini Please review it before the time ends |
|
Don't worry, you will be assigned to the issue and everything will be fine
if you should be chosen as the winner. I've looked at your code and it
works as you described.
…On Tue, 10 Jun 2025, 16:15 Abdullah Al Omar Galib, ***@***.***> wrote:
*ahkatlio* left a comment (moth-quantum/QuantumArtHack#13)
<#13 (comment)>
I have checked this now, and it is good - tomorrow is the last day of the
hackathon, so we will decide on the best implementation then. Thank you for
the submission (sorry I was on vacation until today).
@danielbultrini <https://github.com/danielbultrini> Please review it
before the time ends
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGWKYZ6EZS5TY4CSJ753TI33C3R7ZAVCNFSM6AAAAAB6NQJ46CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJZGQZTCNJUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hello @danielbultrini did you find any winner yet? |
|
Hello @ahkatlio not yet, we have until monday to finalize everything, since the submissions were all good, it will take time to determine the best implementation. |
|
I would say, that if you want to guarantee a win, and you can work on this over the weekend, if you update it so that you slice the second circuit (say, every N gates), and put a connection according to the rule in the middle of the CFRQI/QPIXL circuit, then I would be very happy. |
|
Hello @danielbultrini,
|
|
Okay, this is basically perfect - all that needs to be done is for my sake, could you please make a standalone notebook with this instead of having it in the QPIXL_demo? I would rather put it in myself in a way I think is more consistent. Thank you! |
Done! |
|
Hi @ahkatlio thank you for your work and congratulations! |

fix #3
Overview
This PR confirms that the flexible circuit integration mechanism requested is already implemented in the codebase within:
Implementation Details
The existing implementation satisfies all requirements:
1. Classes and Components
CircuitIntegratorclass - Core integration mechanismIntegrationModeenum - Defines different integration strategies:MERGE: Places circuits side by side with optional connectionsSEQUENTIAL: Applies circuits one after anotherENTANGLE: Connects circuits using specified entangling operationsCUSTOM: Supports user-defined integration rulesQPIXLAlgorithmEncoder- For algorithm integration during encoding2. Key Features
3. Documentation
The notebook already contains clear markdown explanations:
QPIXLAlgorithmEncoderapproachCircuitIntegratorclass and integration modesExamples
Complete demonstration of all integration modes is shown in
demo_qpixl_integrator()function (cell ID "8719b1e3") and practical examples throughout the notebook.