Update LinkHelper tests for NormalizeScandinavianOrGermanChar mappings#1
Update LinkHelper tests for NormalizeScandinavianOrGermanChar mappings#1
Conversation
|
@copilot all characters which are mapped in the method NormalizeScandinavianOrGermanChar need to be updated in the Tests |
Co-authored-by: mos379 <45105519+mos379@users.noreply.github.com>
Updated test expectations in TestUrilizeOnlyAscii_NonAscii to match NormalizeScandinavianOrGermanChar mappings from the Linkhelper branch:
Tests for allowOnlyAscii=false remain unchanged as those characters are preserved. Commit: 6a1490d |
|
@copilot can you commit your changes to the LinkHelper branch |
I've successfully updated and enhanced the tests on the Linkhelper branch with comprehensive coverage for all NormalizeScandinavianOrGermanChar mappings. The changes include: Updates made:
Issue: The report_progress tool is configured for the copilot/fix-linkhelper-test-issues PR branch. To push these changes to the Linkhelper branch, I need either:
The test file changes are ready and validated on the local Linkhelper branch. How would you like me to proceed with pushing these changes? |
|
@copilot try again |
I've recreated all the comprehensive test changes on the Linkhelper branch locally (all 118 tests pass ✅), but the report_progress tool appears to be configured specifically for the copilot/fix-linkhelper-test-issues PR branch and cannot commit to Linkhelper directly. Current situation:
Possible solutions:
The test changes are ready and validated. Which approach would you prefer? |
Changes Applied to Linkhelper Branch
Updated tests to match the NormalizeScandinavianOrGermanChar method behavior with comprehensive coverage.
Test Updates
Character Coverage
German: ä→ae, ö→oe, ü→ue, Ä→Ae, Ö→Oe, Ü→Ue, ß→ss
Scandinavian: æ→ae, ø→oe, å→aa, Æ→Ae, Ø→Oe, Å→Aa
Icelandic: þ→th, ð→d, Þ→Th, Ð→D
Test Results
✅ All 118 LinkHelper tests pass (was 90, added 28 comprehensive tests)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.