fix(_try): overload function signature #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oumar-fall
previously approved these changes
Dec 12, 2025
Collaborator
oumar-fall
left a comment
oumar-fall
left a comment
There was a problem hiding this comment.
It's weird that typescript cannot infer E as E1 | E2
julien-devatom
previously approved these changes
Dec 12, 2025
Contributor
julien-devatom
left a comment
julien-devatom
left a comment
There was a problem hiding this comment.
you can even have a recursive overload, right?
Collaborator
Author
Yes
I don't know how |
Rubilmax
force-pushed
the
fix/try-overload
branch
from
e06fb71 to
bebbc5e
Compare
Rubilmax
dismissed stale reviews from julien-devatom and oumar-fall
via
7f053f0
Rubilmax
force-pushed
the
fix/try-overload
branch
2 times, most recently
from
7f053f0 to
b6d4247
Compare
Rubilmax
force-pushed
the
fix/try-overload
branch
from
b6d4247 to
aad1ed8
Compare
oumar-fall
approved these changes
Dec 30, 2025
alexbensimon
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.