-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
refactor(modals): remove jquery in ts/modals (@fcasibu) #7292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fcasibu
wants to merge
12
commits into
monkeytypegame:master
Choose a base branch
from
fcasibu:refactor/ts-modals-remove-jquery
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor(modals): remove jquery in ts/modals (@fcasibu) #7292
fcasibu
wants to merge
12
commits into
monkeytypegame:master
from
fcasibu:refactor/ts-modals-remove-jquery
+261
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e92798c to
d0997c2
Compare
fcasibu
commented
Dec 25, 2025
| const action = qsr("#editPresetModal .modal").getAttribute("data-action"); | ||
| const propPresetName = qsa<HTMLInputElement>( | ||
| "#editPresetModal .modal input", | ||
| )[0]?.getValue() as string; |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can likely just query for a specific selector, but uncertain. Same for line 237
1f2d152 to
c45226a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
frontend/ts/modals/*to replace jQuery (some still TODO). I've also modifieddom.tsto addsetValueforElementsWithUtils<ElementWithValue>instance. Still trying to grep the whole flow/codebase, so usage ofqsrorqsis uncertain (Probably useqsralways? Can find non-existing elements that way or developer error)While doing the refactor, also stumbled upon things that I have questions for (didn't made any changes to them), which I thought can be improved:
custom-generator.ts:146: The user is able to write minLength > maxLength. Is this behavior correct?custom-test-duration.ts:99: It seems likeparseInput, always expects a non nullable string, and we seem to always expect that#customTestDurationModal inputto always exist (so I usedqsr), which makes the conditionsval !== null,!isNaN(val)seem to be unnecessary (val is never null or NaN, tbh also isFinite, and val >= 0 is the only valid condition)custom-text.ts:169: These elements does not seem exist.randomWordsCheckbox,.replaceNewlineWithSpace,.typographyCheck, and.delimiterCheck(last two is just in a challenge file). Are they good to remove?edit-preset.ts:146: Noticed that we're not updaitng the DOM, since for the most part, in the logic, we mostly usestate.checkboxes, so no problem happens, but I think it is also a good idea to update the DOM to match current state? Either callingupdateUI()here or just changing the checked value inline.Checks
qs,qsaorqsrinstead of JQuery selectors.Related #7186