feat: support 30 min streak offsets (@large-r0dent)

[large-r0dent]

Description

add 30 minute streak offsets as described in #7204

i looked at the backend and i'm pretty sure that no changes are needed there since there's nothing that works with it that wouldn't work with floats.

[fehmer]

hi @large-r0dent ,

thank you for your contribution.

Can you remove the useless comments? For example this comment is just repeating the actual code

const inputValue = parseFloat( // parse float to support fractional stuff

This comment mentiones an issue but not which issue and does not help understand the code.

// 0.0 or 0.5 (assuming we only wanna allow 30 min offsets like in original issue)
  if (value < -11 || value > 12 || (value % 1 !== 0 && value % 1 !== 0.5)) {

What about

const isInvalidHour = value < -11 || value > 12;
const isInvalidMinute = value % 1 !== 0 && value % 1 !== 0.5; //we only support no or thirty minute offsets

if(isInvalidHour || isInvalideMinute) {

This comments are just repeating the name of the constants

  const hours = Math.floor(inputValue); // integer part is hour offset
  const minutes = (inputValue % 1) * 60; // fractional part is minutes

Please check the other comments as well.

[fehmer]

Please add step="0.5" to the input here https://github.com/monkeytypegame/monkeytype/blob/master/frontend/src/html/popups.html#L1063

[fehmer]

Hi @large-r0dent,

please take a look at my comments. Have you tested your changes with a local development environment?

[large-r0dent]

@fehmer @Leonabcd123 sorry, new to oss contribution. will fix + poc test

[github-actions]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

[Copilot]

Pull request overview

This PR adds support for 30-minute increments in streak hour offset configuration. Previously, users could only set offsets in whole hour increments; now they can use values like 5.5 to represent 5 hours and 30 minutes.

Key Changes:

• Modified parsing logic to use parseFloat instead of parseInt to handle fractional values
• Updated date manipulation to calculate hours and minutes separately from the fractional input
• Enhanced validation to allow values ending in .5 for 30-minute increments

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
frontend/src/ts/modals/streak-hour-offset.ts	Updated parsing logic to support floats, refactored date manipulation to handle fractional hours, and updated validation and error messages
frontend/src/html/popups.html	Added step attribute to allow 0.5 increments in the number input

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Leonabcd123]

Here we call it Streak hour offset, but previously we've called it Streak time offset. Please be more consistent with the naming.

[Miodec]

I think i would revert the change to "time" and just keep it "hour" everywhere. Half hours are still hours.

[large-r0dent]

@Miodec :thumbs_up:

[fehmer]

revert?