P2: Usage examples moved to appropriate pages#624
P2: Usage examples moved to appropriate pages#624rachel-mack merged 19 commits intomongodb:masterfrom
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
left a comment
rustagir
left a comment
There was a problem hiding this comment.
few important maintenance issues
| @@ -1,13 +1,27 @@ | |||
| .. _java-usage-count: | |||
| .. _java-count: | |||
There was a problem hiding this comment.
S: per the renaming guidance, leave old anchors in place
Q: will there be redirects for moving these pages around?
There was a problem hiding this comment.
I moved this tag down to the Count Documents Example: Full File, so that anyone referencing it will still be taking to the example.
rustagir
left a comment
rustagir
left a comment
There was a problem hiding this comment.
lgtm with a few small nits!
|
This ready for tech review. |
| In this guide, you can learn how to retrieve a list of distinct values for a | ||
| field across a collection by calling the ``distinct()`` method on a | ||
| ``MongoCollection`` object. Pass the document field name as the first parameter | ||
| and the class you want to cast the results to as the second parameter as shown |
There was a problem hiding this comment.
Technically, it's not a cast, since it's a generic type.
There was a problem hiding this comment.
changed to:
...and the class you want to use for the results format as the second parameter...
Let me know what you think
| ~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The ``watch()`` method optionally takes an **aggregation pipeline** which | ||
| consists of an array of **stages** as the first parameter to filter and |
There was a problem hiding this comment.
Consider changing to: ".... as the first parameter, which can be used to filter and transform the change event output, as follows:`
rachel-mack
force-pushed
the
DOCSP-47267-P2
branch
from
ab337fc to
560672c
Compare
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
One grammar nit remaining, but I'll LGTM based on the technical content.
| In this guide, you can learn how to retrieve a list of distinct values for a | ||
| field across a collection by calling the ``distinct()`` method on a | ||
| ``MongoCollection`` object. Pass the document field name as the first parameter | ||
| and the class you want to use for the results format as the second parameter as shown |
There was a problem hiding this comment.
| and the class you want to use for the results format as the second parameter as shown | |
| and the class you want to use for the results as the second parameter, as shown |
| Filter the Events | ||
| ~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The ``watch()`` method optionally takes an **aggregation pipeline** which |
There was a problem hiding this comment.
This still doesn't read well to my ears. To many "which"s. Can you try to re-word it?
3 participants
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47267
Staging Links
Self-Review Checklist