DOCSP-47032: Network compression#622
Merged
norareidy merged 6 commits intomongodb:masterfrom Mar 5, 2025
Merged
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lindseymoore
approved these changes
Feb 21, 2025
Comment on lines
55
to
56
| - Use the ``compressors`` parameter in your connection string | ||
| - Chain the ``compressorList()`` method to the ``MongoClientSettings.builder()`` method |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Use the ``compressors`` parameter in your connection string | |
| - Chain the ``compressorList()`` method to the ``MongoClientSettings.builder()`` method | |
| - Use the ``compressors`` parameter in your connection string. | |
| - Chain the ``compressorList()`` method to the ``MongoClientSettings.builder()`` method. |
S: Would use a period since there is an implied you.
norareidy
requested review from
NathanQingyangXu
and removed request for
a team
NathanQingyangXu
suggested changes
Mar 5, 2025
| MongoClient client = MongoClients.create(settings); | ||
| .. literalinclude:: /includes/connect/NetworkCompression.java | ||
| :start-after: start-specify-uri | ||
| :end-before: end-specify-uri |
There was a problem hiding this comment.
the start-specify-uri and end-specify-uri look confusing to me, for there is no uri involved here.
maybe better naming like start-use-client-settings-builder?
Contributor
Author
There was a problem hiding this comment.
Yes good catch, I'll update these comments!
| `zstd-java <https://github.com/luben/zstd-jni>`__ for details. | ||
| The JDK natively supports `Zlib <https://zlib.net/>`__ compression. However, | ||
| Snappy and Zstandard depend on open source Java implementations. To learn more | ||
| about these implementations, see the following Github repositories: |
There was a problem hiding this comment.
Suggested change
| about these implementations, see the following Github repositories: | |
| about these implementations, see the following GitHub repositories: |
NathanQingyangXu
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47032
Staging Links
Self-Review Checklist