Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Feb 9, 2026

I'm going through ELSPROBLEMS that will start to show up when using npm@11 in compass monorepo, some of them are legit-ish issues that are just not spotted by npm@10

This particular patch with puppeteer-core issue and some related clean-up:

  • Remove override for puppeteer-core: it was added some time ago to deal with webdriver peer requiring a version that was causing us issue, but override wasn't applied (there are some issues with overrides and peerDependencies) and so with npm@11 existin issue there started to be reported. The fix is to just remove the override and update webdriverio to the version that specifies the range correctly
  • Updating webdriverio to latest required some slight changes in the code as the types are now a bit stricter
  • Remove @wdio/types dependency: I'm not exactly sure for what reason this was added, but it's not needed and is not matching the version of the webdriverio package we are using, so removed it

TTFQ e2e test passed for me locally, CI should show if I accidentally broke something else

@gribnoysup gribnoysup requested a review from a team as a code owner February 9, 2026 14:05
@gribnoysup gribnoysup requested a review from Anemy February 9, 2026 14:05
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Feb 9, 2026
@codeowners-service-app
Copy link

Assigned mabaasit for team compass-developers because Anemy is out of office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant