chore(deps): update leafygreen to latest #7775
Open
+36
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-devtools-bot
bot
added
bot
no-title-validation
gribnoysup
approved these changes
Feb 9, 2026
Collaborator
There was a problem hiding this comment.
@mabaasit fix looks good, but you can make the code better by avoiding unnecessary explicit type assertions
Comment on lines
568
to
570
| const role = (await messageElement.getAttribute('data-role')) as | ||
| | 'user' | ||
| | 'assistant'; |
Collaborator
There was a problem hiding this comment.
Instead of asserting types, you can add an actual check, which will not only satisfy typescript, but also will make sure that if this breaks, the error points out better what exactly broke
Suggested change
| const role = (await messageElement.getAttribute('data-role')) as | |
| | 'user' | |
| | 'assistant'; | |
| const role = await messageElement.getAttribute('data-role') | |
| if (role !== 'user' && role !== 'assistant') { | |
| throw new Error(`Expected data-role to be user | assistant, got ${role}`); | |
| } |
…compass into ci/update-leafygreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is automatically generated and updates the versions of the dependency group leafygreen to latest version.
If CI is green on this patch you should feel free to merge it at your convenience.
If CI is red and you think that failures are related to the version updates, you should raise an issue, so that it can be manually resolved and we can continue to update the package group to latest.