fix: add bookkeeping for number of active subscriptions #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitarua
force-pushed
the
subscriptions-bookkeeping
branch
from
b0b798c to
31c5499
Compare
…l, not just on unsubscribe
anitarua
force-pushed
the
subscriptions-bookkeeping
branch
from
6f6ffd6 to
69250c6
Compare
malandis
reviewed
Jun 4, 2025
momento-sdk/src/intTest/java/momento/sdk/retry/TopicsSubscriptionInitializationTest.java
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/ScsTopicGrpcStubsManager.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/ScsTopicGrpcStubsManager.java
Outdated
Show resolved
Hide resolved
malandis
approved these changes
Jun 4, 2025
Comment on lines
+150
to
+160
| for (int i = 0; i < maximumActiveSubscriptions; i++) { | ||
| final StreamStubWithCount stubWithCount = | ||
| streamStubs.get(streamIndex.getAndIncrement() % this.numStreamGrpcChannels); | ||
| try { | ||
| stubWithCount.acquireStubOrThrow(); | ||
| return stubWithCount; | ||
| } catch (ClientSdkException e) { | ||
| // If the stub is at capacity, continue to the next one. | ||
| continue; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards https://github.com/momentohq/dev-eco-issue-tracker/issues/1231
Found that the java sdk does not keep track of the number of concurrent subscriptions while auditing the implementations of separate grpc channels for publish and subscribe.
Also added a new retry test file to verify that the TopicClient does not allow >100 streams on a single grpc channel and that it is capable of handling bursts of subscribe and unsubscribe requests.
Note: this PR is based on top of Nate's PR for other subscriptions improvements