Compatibility with Raspberry Pi 5 #141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to create a fork of this library that can work with either libgpiod for Raspberry Pi 5 compatibility, or can continue to be used with the BCM2835 library for older hardware.
Since I've made changes to documentation and version numbers in my fork which I'm sure you wouldn't want to pull in into your master branch (in case my fork simply goes off on its own independently) I'm submitting this PR more as a way for you to look at the diff decide if you like the overall direction of my changes.
If you decide you would like to use all or part of what I've done here I can create a new branch of my own, versioned as node-dht-sensor and not node-dht-sensor-rp5, and I could re-submit a PR from that branch to a different different (perhaps newly-created) branch of your choosing rather than master.
I should also note that, while I would have like to have run your mocha tests before submitting this PR, I couldn't even get
npm run testto work on your unmodified master branch -- too many tool and library dependencies for me to overcome to make the test work.