Skip to content

Conversation

@kshetline
Copy link
Contributor

@kshetline kshetline commented Feb 14, 2025

I've managed to create a fork of this library that can work with either libgpiod for Raspberry Pi 5 compatibility, or can continue to be used with the BCM2835 library for older hardware.

Since I've made changes to documentation and version numbers in my fork which I'm sure you wouldn't want to pull in into your master branch (in case my fork simply goes off on its own independently) I'm submitting this PR more as a way for you to look at the diff decide if you like the overall direction of my changes.

If you decide you would like to use all or part of what I've done here I can create a new branch of my own, versioned as node-dht-sensor and not node-dht-sensor-rp5, and I could re-submit a PR from that branch to a different different (perhaps newly-created) branch of your choosing rather than master.

I should also note that, while I would have like to have run your mocha tests before submitting this PR, I couldn't even get npm run test to work on your unmodified master branch -- too many tool and library dependencies for me to overcome to make the test work.

@momenso momenso self-assigned this Feb 14, 2025
@momenso
Copy link
Owner

momenso commented Feb 14, 2025

Hi @kshetline,

Thanks for your contribution and for taking the time to submit this PR. I truly appreciate the effort you've put into enhancing compatibility with Raspberry Pi 5 and maintaining support for older hardware!

You've clearly approached this with care, and I appreciate your willingness to share your work even if it may not align directly with our master branch. Your documentation updates and versioning adjustments show a lot of consideration for the project's direction.

However, since this PR references your forked repository with distinct versioning and documentation paths, we are unable to merge it into the master branch as-is. To maintain consistency and avoid potential conflicts, we can only merge contributions that are based directly on our repository.

That said, I am very interested in your improvements! If you would like to submit a new PR from a branch in your fork that mirrors our repository's structure (e.g., with node-dht-sensor naming and without versioning changes), we'd be happy to review it.

We also appreciate your note about the test suite issues. Improving the testing process is on our radar, and your feedback helps us prioritize that.

Thank you again for your dedication and for sharing your insights. We hope to collaborate with you further!

@kshetline
Copy link
Contributor Author

I definitely anticipated the need to use an alternate branch with my versioning changes and a few other changes removed, I just wanted to make sure the interest was there in using my work before I took that step. Perhaps, to also may this easier, you could create a new copy of the master branch for me to target?

@momenso
Copy link
Owner

momenso commented Feb 15, 2025

I saw your new PR #143 , so lets close this one and work from there.

@momenso momenso closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants