Export cleanup function from register entry-point#239
Open
perrin4869 wants to merge 1 commit intomodosc:mainfrom
Open
Export cleanup function from register entry-point#239perrin4869 wants to merge 1 commit intomodosc:mainfrom
perrin4869 wants to merge 1 commit intomodosc:mainfrom
Conversation
Owner
|
thanks @perrin4869 - this is a good idea but i'd like to keep things similar to the non-register case, and i'm not clear on the best way forward. one option might be to explicitly provide a named granted this would be a breaking change but it seems a lot cleaner than the existing implementations. what do you think? |
Author
|
Hm... I don't know, I find it quite natural that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought that this could be useful in a few cases, but please ignore this if you feel it's not worth it.
Could help keep some code a little bit cleaner