Skip to content

Fix default tinyint values #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugopeek wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix default tinyint values #460

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59cb375
Reset unset tinyint values to default on build
hugopeek Sep 14, 2025
7649d21
Skip excluded fields when applying tinyint defaults
hugopeek Sep 15, 2025
0518dac
Merge branch 'modmore:master' into fix-default-tinyint-values
hugopeek Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Command/BuildCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,24 @@ public function buildSingleObject($data, $type, $isConflictResolution = false) {
$catName = $data['category'];
$data['category'] = $this->getCategoryId($catName);
}

// Make sure default value is applied to empty tinyint fields
foreach ($object->_fieldMeta as $key => $value) {
if ($value['dbtype'] == 'tinyint') {
$excludes = (isset($type['exclude_keys']) && is_array($type['exclude_keys'])) ? $type['exclude_keys'] : array();

// Skip fields that are explicitly defined OR excluded in YAML config
if (isset($data[$key]) || in_array($key, $excludes)) continue;

// Reset fields with a value other than the default
if (isset($value['default']) && $object->get($key) != $value['default']) {
if ($this->output->isVerbose()) {
$this->output->writeln("- Resetting <comment>$key</comment> field to default value for <comment>" . $object->get('name') . "</comment> object.");
}
$data[$key] = $value['default'];
}
}
}
}

$object->fromArray($data, '', true, true);
Expand Down