Skip to content

exclude metrics and health checks path from OTL #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Mar 31, 2025
Merged

exclude metrics and health checks path from OTL #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lite_bootstrap/bootstrappers/fastapi_bootstrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,19 @@ class FastAPILoggingInstrument(LoggingInstrument):
class FastAPIOpenTelemetryInstrument(OpenTelemetryInstrument):
bootstrap_config: FastAPIConfig

def _build_excluded_urls(self) -> list[str]:
excluded_urls = [*self.bootstrap_config.opentelemetry_excluded_urls]
for one_url in (self.bootstrap_config.health_checks_path, self.bootstrap_config.prometheus_metrics_path):
if one_url and one_url not in excluded_urls:
excluded_urls.append(one_url)
return excluded_urls

def bootstrap(self) -> None:
super().bootstrap()
FastAPIInstrumentor.instrument_app(
app=self.bootstrap_config.application,
tracer_provider=get_tracer_provider(),
excluded_urls=",".join(self.bootstrap_config.opentelemetry_excluded_urls),
excluded_urls=",".join(self._build_excluded_urls()),
)

def teardown(self) -> None:
Expand Down
9 changes: 8 additions & 1 deletion lite_bootstrap/bootstrappers/litestar_bootstrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,19 @@ class LitestarLoggingInstrument(LoggingInstrument):
class LitestarOpenTelemetryInstrument(OpenTelemetryInstrument):
bootstrap_config: LitestarConfig

def _build_excluded_urls(self) -> list[str]:
excluded_urls = [*self.bootstrap_config.opentelemetry_excluded_urls]
for one_url in (self.bootstrap_config.health_checks_path, self.bootstrap_config.prometheus_metrics_path):
if one_url and one_url not in excluded_urls:
excluded_urls.append(one_url)
return excluded_urls

def bootstrap(self) -> None:
super().bootstrap()
self.bootstrap_config.application_config.middleware.append(
OpenTelemetryConfig(
tracer_provider=get_tracer_provider(),
exclude=self.bootstrap_config.opentelemetry_excluded_urls,
exclude=self._build_excluded_urls(),
).middleware,
)

Expand Down