Skip to content

Feat/webui code genesis #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinci-grape wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feat/webui code genesis #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9514bdc
feat: webui_code_gengesis
vinci-grape Jan 26, 2026
ee8ab3a
fix bug
vinci-grape Jan 26, 2026
f13c185
remove package.json
vinci-grape Jan 26, 2026
e5fa939
remove .npm-cache
vinci-grape Jan 26, 2026
190fba7
remove package-lock.json
vinci-grape Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 35 additions & 13 deletions ms_agent/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) ModelScope Contributors. All rights reserved.
# Copyright (c) Alibaba, Inc. and its affiliates.
import argparse
import os.path
from abc import abstractmethod
Expand Down Expand Up @@ -108,7 +108,10 @@ def fill_missing_fields(config: DictConfig) -> DictConfig:
@staticmethod
def is_workflow(config: DictConfig) -> bool:
assert config.name is not None, 'Cannot find a valid name in this config'
return config.name in ['workflow.yaml', 'workflow.yml']
return config.name in [
'workflow.yaml', 'workflow.yml', 'simple_workflow.yaml',
'simple_workflow.yml'
]

@staticmethod
def parse_args() -> Dict[str, Any]:
Expand All @@ -124,15 +127,6 @@ def parse_args() -> Dict[str, Any]:
_dict_config[key[2:]] = value
return _dict_config

@staticmethod
def safe_get_config(config: DictConfig, keys: str) -> Any:
node = config
for key in keys.split('.'):
if not hasattr(node, key):
return None
node = getattr(node, key)
return node

@staticmethod
def _update_config(config: Union[DictConfig, ListConfig],
extra: Dict[str, str] = None):
Expand All @@ -151,14 +145,42 @@ def traverse_config(_config: Union[DictConfig, ListConfig, Any],
if current_path in extra:
logger.info(
f'Replacing {current_path} with extra value.')
setattr(_config, name, extra[current_path])
# Convert temperature to float and max_tokens to int if they're numeric strings
value_to_set = extra[current_path]
if name == 'temperature' and isinstance(
value_to_set, str):
try:
value_to_set = float(value_to_set)
except (ValueError, TypeError):
pass
elif name == 'max_tokens' and isinstance(
value_to_set, str):
try:
value_to_set = int(value_to_set)
except (ValueError, TypeError):
pass
setattr(_config, name, value_to_set)
Comment on lines +148 to +162
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for converting temperature to float and max_tokens to int is duplicated here and in the elif block below. Consider extracting this conversion logic into a small helper function to improve maintainability and reduce redundancy.

# Find the key in extra that matches name (case-insensitive)
elif (key_match := next(
(key
for key in extra if key.lower() == name.lower()),
None)) is not None:
logger.info(f'Replacing {name} with extra value.')
setattr(_config, name, extra[key_match])
# Convert temperature to float and max_tokens to int if they're numeric strings
value_to_set = extra[key_match]
if name == 'temperature' and isinstance(
value_to_set, str):
try:
value_to_set = float(value_to_set)
except (ValueError, TypeError):
pass
elif name == 'max_tokens' and isinstance(
value_to_set, str):
try:
value_to_set = int(value_to_set)
except (ValueError, TypeError):
pass
setattr(_config, name, value_to_set)
Comment on lines +169 to +183
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block duplicates the type conversion logic for temperature and max_tokens found earlier in the if current_path in extra: block. Encapsulating this into a helper function would make the code cleaner and easier to maintain.

# Handle placeholder replacement like <api_key>
elif (isinstance(value, str) and value.startswith('<')
and value.endswith('>')
Expand Down
104 changes: 97 additions & 7 deletions ms_agent/tools/filesystem_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) ModelScope Contributors. All rights reserved.
# Copyright (c) Alibaba, Inc. and its affiliates.
import fnmatch
import os
import re
Expand All @@ -8,12 +8,12 @@
from typing import Optional

import json
from ms_agent.config import Config
from ms_agent.llm import LLM
from ms_agent.llm.utils import Message, Tool
from ms_agent.tools.base import ToolBase
from ms_agent.utils import get_logger
from ms_agent.utils import MAX_CONTINUE_RUNS, get_logger, retry
from ms_agent.utils.constants import DEFAULT_INDEX_DIR, DEFAULT_OUTPUT_DIR
from openai import OpenAI

logger = get_logger()

Expand Down Expand Up @@ -46,6 +46,13 @@ def __init__(self, config, **kwargs):
super().__init__(config)
self.exclude_func(getattr(config.tools, 'file_system', None))
self.output_dir = getattr(config, 'output_dir', DEFAULT_OUTPUT_DIR)
if self.exclude_functions and 'edit_file' not in self.exclude_functions \
or self.include_functions and 'edit_file' in self.include_functions:
self.edit_file_config = getattr(config.tools.file_system,
'edit_file_config', None)
self.edit_client = OpenAI(
api_key=self.edit_file_config.api_key,
base_url=self.edit_file_config.base_url)
self.trust_remote_code = kwargs.get('trust_remote_code', False)
self.allow_read_all_files = getattr(
getattr(config.tools, 'file_system', {}), 'allow_read_all_files',
Expand All @@ -57,10 +64,8 @@ def __init__(self, config, **kwargs):
index_dir = getattr(config, 'index_cache_dir', DEFAULT_INDEX_DIR)
self.index_dir = os.path.join(self.output_dir, index_dir)
self.system = self.SYSTEM_FOR_ABBREVIATIONS
system = Config.safe_get_config(
self.config, 'tools.file_system.system_for_abbreviations')
if system:
self.system = system
if hasattr(self.config.tools.file_system, 'system_for_abbreviations'):
self.system = self.config.tools.file_system.system_for_abbreviations

async def connect(self):
logger.warning_once(
Expand Down Expand Up @@ -196,6 +201,65 @@ async def _get_tools_inner(self):
'required': ['path'],
'additionalProperties': False
}),
Tool(
tool_name='edit_file',
server_name='file_system',
description=
('Use this tool to make an edit to an existing file.\n\n'
'This will be read by a less intelligent model, which will quickly apply the edit. '
'You should make it clear what the edit is, while also minimizing the unchanged code you write.\n'
'When writing the edit, you should specify each edit in sequence, with the special comment '
'// ... existing code ... to represent unchanged code in between edited lines.\n\n'
'For example:\n\n// ... existing code ...\nFIRST_EDIT\n// ... existing code ...\n'
'SECOND_EDIT\n// ... existing code ...\nTHIRD_EDIT\n// ... existing code ...\n\n'
'You should still bias towards repeating as few lines of the original file '
'as possible to convey the change.\n'
'But, each edit should contain minimally sufficient context of unchanged lines '
"around the code you're editing to resolve ambiguity.\n"
'DO NOT omit spans of pre-existing code (or comments) without using the '
'// ... existing code ... comment to indicate its absence. '
'If you omit the existing code comment, the model may inadvertently delete these lines.\n'
'If you plan on deleting a section, you must provide context before and after to delete it. '
'If the initial code is ```code \\n Block 1 \\n Block 2 \\n Block 3 \\n code```, '
'and you want to remove Block 2, you would output '
'```// ... existing code ... \\n Block 1 \\n Block 3 \\n // ... existing code ...```.\n'
'Make sure it is clear what the edit should be, and where it should be applied.\n'
'Make edits to a file in a single edit_file call '
'instead of multiple edit_file calls to the same file. '
'The apply model can handle many distinct edits at once.'
),
parameters={
'type': 'object',
'properties': {
'path': {
'type': 'string',
'description':
'Path of the target file to modify.'
},
'instructions': {
'type':
'string',
'description':
('A single sentence instruction describing '
'what you are going to do for the sketched edit. '
'This is used to assist the less intelligent model in applying the edit. '
'Use the first person to describe what you are going to do. '
'Use it to disambiguate uncertainty in the edit.'
)
},
'code_edit': {
'type':
'string',
'description':
('Specify ONLY the precise lines of code that you wish to edit. '
'NEVER specify or write out unchanged code. '
'Instead, represent all unchanged code using the comment of the language '
"you're editing in - example: // ... existing code ..."
)
}
},
'required': ['path', 'instructions', 'code_edit']
}),
Tool(
tool_name='search_file_content',
server_name='file_system',
Expand Down Expand Up @@ -936,3 +1000,29 @@ async def list_files(self, path: str = None):
except Exception as e:
return f'List files of <{path or "root path"}> failed, error: ' + str(
e)

@retry(max_attempts=MAX_CONTINUE_RUNS, delay=1.0)
async def edit_file(self,
path: str = None,
instructions: str = None,
code_edit: str = None):
try:
with open(os.path.join(self.output_dir, path), 'r') as f:
initial_code = f.read()
response = self.edit_client.chat.completions.create(
model=self.edit_file_config.diff_model,
messages=[{
'role':
'user',
'content':
(f'<instruction>{instructions}</instruction>\n'
f'<code>{initial_code}</code>\n'
f'<update>{code_edit}</update>')
}])
merged_code = response.choices[0].message.content

with open(os.path.join(self.output_dir, path), 'w') as f:
f.write(merged_code)
return f'Edit file <{path}> successfully.'
except Exception as e:
return f'Edit file <{path}> failed, error: ' + str(e)
16 changes: 0 additions & 16 deletions projects/code_genesis/ROADMAP.md
View file
Open in desktop

This file was deleted.

Loading
Loading