Make use of variadic macro for logging call. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function clog_info (/_debug/..) is now replaced by a variadic macro that "knows" the linenumber where it is. This change is due, because the dependency on `va_copy` already kind of enforces the use of C99 or later. This very much simplifies the use of the logger: Instead of typing clog_info(CLOG(my_logger_id), "Hello, %s!", "world"); if suffices to pass the logger id: clog_info(my_logger_id, "Hello, %s!", "world"); The replacement depends on the C/C++ version used (variadic macros are part of the standard since C99/C++11). The preprocessor checks for the version and defines the macro if applicable. This is backwards compatible, because if the macros are defined, then CLOG(id) is defined as the identity function doing nothing.
This should make it platform independent and just as well usable on windows. TODO: This broke the test cases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function clog_info (/_debug/..) is now replaced by
a variadic macro that "knows" the linenumber where it is.
This change is due, because the dependency on
va_copyalready kind of enforces the use of C99 or later.
This very much simplifies the use of the logger:
Instead of typing
clog_info(CLOG(my_logger_id), "Hello, %s!", "world");
if suffices to pass the logger id:
clog_info(my_logger_id, "Hello, %s!", "world");
The replacement depends on the C/C++ version used
(variadic macros are part of the standard since C99/C++11).
The preprocessor checks for the version and defines the
macro if applicable.
This is backwards compatible, because if the macros are
defined, then CLOG(id) is defined as the identity function
doing nothing.