Merged
Conversation
TODO Functionality is not yet implemented.
- added some EvE-states - added some EvE-mutations - added EvEtrue (which provides a limiter-implementation) - added EvEfalse Engine vs. Engine mode is now usable :)
Changes: - Startgame-button now overwrites variant in store - EvE-Engines now play on the specific variant - EvE-Engines now play different, wether the game is a 960 game or not - PvE should be available again :)
tested popup for PvP, PvE, EvE and games outside of NewGameButton. Tested win/draw/loss/scenario
removed PvE settings from the settings tab and all functionality in SettingsTab that was connected to it. Added a close button instead
buttons are now clickable and don´t overlap
GameEndModal and StartGameModal now support dark mode.
pgn browser is now removed from the left side of the gui and made accessible via a new button. the pgn browser itself might not work properly and needs to be fixed
- added isPlayerTurn() and boardPointerEvents to ChessGround.vue to block mouse input when it is not the players turn - fixed EvE not working in AnalysisHead
- limiter for PvE-engine is now working - disabled engine-arrows, which showed the best move in current position
An import was missing, it probably got lost during merging
- moved the data of the NewGameModal to store.js - resetAllSettings now resets the data of the NewGameModal
- fixed the bug where playing EvP then PvE causes the engine to play a move for the player - this might have fixed the EvE bug too
The "Start Game" button of the StartGameModal gets disabled when for one of the participating Engines no Engine is selected. A little message next to the button informs the player of the reason.
- the limiter value in the StartGameModal can now be empty - the start game button gets blocked when a limiter field contains an invalid value - this change was required because previously changing the value from 1000 to 2000 required the user to change it to 12000 and then delete the leading 1 because deleting it first would result in 000 as an intermediate step which would reset to 1000
- the reset board button now cancels any running game started via the StartGameModal
changed project folder, apperently the engine binaries changed because of that
Collaborator
|
Every previous bug fixed. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Pre-merge TODOs and Checks