Support building on macOS host #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queueRAM
commented
Jan 3, 2026
Contributor
Author
queueRAM
left a comment
queueRAM
left a comment
There was a problem hiding this comment.
i broke up the PRs by problem category to make them more easily reviewable and focused in case a future revert is needed.
Makefile
Outdated
|
|
||
| verify: $(TARGET).z64 | ||
| @echo "$$(cat $(BASENAME).$(VERSION).sha1) $(TARGET).z64" | sha1sum --check | ||
| @echo "$$(cat $(BASENAME).$(VERSION).sha1) $(TARGET).z64" | sha1sum --check - |
Contributor
Author
There was a problem hiding this comment.
could also use $< instead of $(TARGET).z64
| XGCC = $(CROSS)gcc | ||
|
|
||
| # prefer modern gcc for data, but fall back to IDO if not available | ||
| ifneq (,$(call find-command,$(CROSS)gcc)) |
queueRAM
force-pushed
the
support_macos_host
branch
from
367f4ff to
c641b79
Compare
queueRAM
commented
Jan 4, 2026
|
|
||
| ### Recipes | ||
|
|
||
| .baserom.$(VERSION).ok: baserom.$(VERSION).z64 |
Contributor
Author
There was a problem hiding this comment.
per discussion in Discord, splat has built-in sha1 checks, so this Makefile-level check appears redundant. open to further feedback here
Tweak Makefile to support building on macOS host - splat has built-in sha1 checks during extract, so remove check and .ok targets - properly format sha1 file for build check to support GNU and BSD sha1sum - prefer building data with XGCC, but fall back on IDO if not available
queueRAM
force-pushed
the
support_macos_host
branch
from
c641b79 to
fd7c78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak Makefile to support building on macOS host
-to read from stdin