Refactor: Eliminate LiveView Anti-patterns in Dashboard V2

[mjc]

Overview

This PR eliminates several LiveView anti-patterns and indirection layers in , resulting in cleaner, more maintainable, and better-performing code.

Key Improvements

🏗️ Architecture Improvements

• Eliminated defstruct usage in socket assigns for direct access patterns
• Flattened nested state structures to improve performance and readability
• Removed unnecessary indirection with direct, testable function calls

🔧 Code Quality Enhancements

• Consolidated repetitive event handlers into unified functions
• Added proper Broadway pipeline checking using Process.whereis/1 and Process.alive?/1
• Fixed Credo compliance by using implicit try instead of explicit try/catch
• Improved service control reliability with actual process state verification

📊 Performance Benefits

• Direct socket assign access eliminates struct overhead
• Reduced function call depth improves LiveView update cycles
• More efficient state management patterns

Technical Details

State Management Before/After

# Before: Nested defstruct with indirection
defmodule State do
  defstruct [:services, :videos, :stats]
end

# After: Direct socket assigns
socket.assigns.services
socket.assigns.videos  
socket.assigns.stats

Service Control Improvements

# Before: Boolean-based checks
def service_available?(service), do: service.available

# After: Actual process verification
defp broadway_running?(broadway_module) do
  case Process.whereis(broadway_module) do
    nil -> false
    pid when is_pid(pid) -> Process.alive?(pid)
  end
rescue
  _ -> false
end

Quality Assurance

• ✅ All tests passing (577 tests, 0 failures)
• ✅ Zero compilation warnings
• ✅ Credo strict mode compliance
• ✅ Code formatting validated
• ✅ Pre-commit hooks passed
• ✅ All existing functionality preserved

Impact

• Maintainability: Reduced code complexity and eliminated anti-patterns
• Performance: More efficient state management and update cycles
• Reliability: Better service control with actual process state checking
• Code Quality: Full Credo compliance and improved readability

No breaking changes - all existing dashboard functionality and real-time updates work exactly as before.

[Copilot]

Pull Request Overview

This PR refactors the DashboardV2Live module to eliminate LiveView anti-patterns by flattening nested structures, removing indirection layers, and improving service control reliability. The refactor consolidates repetitive event handlers and implements proper Broadway pipeline checking using actual process state verification.

Key changes:

• Inline event handler logic to eliminate unnecessary abstraction layers
• Replace indirect service control with direct Broadway process checking
• Add proper process state verification using Process.alive?/1 instead of just existence checks

[Copilot]

Pull Request Overview

Copilot reviewed 57 out of 70 changed files in this pull request and generated 6 comments.