Skip to content

Comments

Navgrid Based Start Tolerance for Pathfinding#1115

Open
c-eid wants to merge 2 commits intomjansen4857:mainfrom
c-eid:NavgridBasedStartTolerence
Open

Navgrid Based Start Tolerance for Pathfinding#1115
c-eid wants to merge 2 commits intomjansen4857:mainfrom
c-eid:NavgridBasedStartTolerence

Conversation

@c-eid
Copy link

@c-eid c-eid commented Aug 30, 2025

Changed the minimum start distance from a hardcoded 0.5 to the diagonal of the current navgrid size.

@c-eid
Copy link
Author

c-eid commented Sep 28, 2025

@mjansen4857 Friendly ping, this is a very simple change, even if there's plans to completely overhaul pathfinding itd be nice to have this work till then.

@mjansen4857
Copy link
Owner

Needs C++ and python. I can help if needed

@c-eid
Copy link
Author

c-eid commented Nov 8, 2025

Needs C++ and python. I can help if needed

Im not familiar with wpilib Python and C++ so I probably would not be able to help with that unfortunately.

@mjansen4857
Copy link
Owner

Actually, looking at this more, this needs some reworking. Calling the get navgrid size method in execute means reading the file every loop, which is very slow. Also, the pathfinding command can't use anything related to a navgrid without breaking the ability to use custom pathfinders. This really just has to be an overload constructor for tolerance or something. Finally, the check for being within 2 meters should remain 2 meters instead of based on that tolerance. That's just ignoring updates when unnecessary which shouldn't really change.

@c-eid
Copy link
Author

c-eid commented Jan 12, 2026

Finally, the check for being within 2 meters should remain 2 meters

I just assumed that was necessary because I seen another PR with that in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PathPlannerLib Changes to PathPlannerLib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants