improved error logging of PathPlannerPath::samplePath#1101
Open
aolgeirson wants to merge 2 commits intomjansen4857:mainfrom
Open
improved error logging of PathPlannerPath::samplePath#1101aolgeirson wants to merge 2 commits intomjansen4857:mainfrom
aolgeirson wants to merge 2 commits intomjansen4857:mainfrom
Conversation
mjansen4857
reviewed
Apr 10, 2025
Comment on lines
+932
to
+935
| if (!m_waypoints.at(i+1).nextControl) { | ||
| throw std::runtime_error( | ||
| "PathPlannerPath::samplePath: Waypoint " + std::to_string(i+1)+ " .nextControl is null"); | ||
| } |
Owner
There was a problem hiding this comment.
This would always fail for every path. The end waypoint does not have a nextControl point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1100 added logging, however a non-crashing outcome would be ideal as the exception won't be handled