fix: convert Buffer to Uint8Array for browser hydration compatibility#36
Open
boomyao wants to merge 1 commit intomizzle-dev:mainfrom
Open
fix: convert Buffer to Uint8Array for browser hydration compatibility#36boomyao wants to merge 1 commit intomizzle-dev:mainfrom
boomyao wants to merge 1 commit intomizzle-dev:mainfrom
Conversation
The workflow web inspect now performs client-side hydration using hydrateData() from @workflow/core/serialization-format. This function checks for Uint8Array using instanceof, which fails for Buffer in the browser since Buffer doesn't exist in browser environments. This fix ensures that MongoDB Binary data is converted to true Uint8Array before being returned, enabling proper data hydration in workflow web inspect. Changes: - Add bufferToUint8Array() helper function - Update stripUndefined() to convert Buffer/Binary to Uint8Array - Update cleanMongoDoc() to convert Buffer/Binary to Uint8Array - Update dependencies to latest workflow versions Signed-off-by: Assistant <assistant@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
97ff0ad to
3c3cdc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workflow web inspect (>= 4.1.0-beta.56) now performs client-side hydration using
hydrateData()from@workflow/core/serialization-format. This function checks forUint8Arrayusinginstanceof, which fails forBufferin the browser sinceBufferdoesn't exist in browser environments.This fix ensures that MongoDB Binary data is converted to true
Uint8Arraybefore being returned, enabling proper data hydration in workflow web inspect.Changes
bufferToUint8Array()helper functionstripUndefined()to convert Buffer/Binary to Uint8ArraycleanMongoDoc()to convert Buffer/Binary to Uint8ArrayCompatibility
Uint8Arrayis a parent class ofBuffer, so existing code continues to workTesting
All 55 tests pass:
Signed-off-by: Assistant assistant@cursor.com
Made with Cursor