Draft
Conversation
- Make hook creation atomic by using the unique index on token instead of a check-then-insert pattern, which had a TOCTOU race condition - Properly catch MongoDB duplicate key errors (code 11000) and convert to 409 - Add debug logging to hooks create, get, and getByToken operations - Add comprehensive webhook flow tests to the testing package: - Test creating and retrieving hooks with random tokens (like e2e test) - Test concurrent hook creation and lookup - Test that getByToken returns 404 for non-existent tokens - Test immediate visibility of hooks after creation These changes help diagnose and potentially fix the MongoDB e2e test failure where webhookWorkflow gets 404 instead of 202.
Contributor
Benchmark ComparisonCross-comparison of workflow performance across World implementations.
workflow with no steps
workflow with 1 step
workflow with 10 sequential steps
workflow with 10 parallel steps
Stream BenchmarksStream benchmarks include Time to First Byte (TTFB) metrics. workflow with stream
Summary: Average Performance by World
Column Definitions
Worlds:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes help diagnose and potentially fix the MongoDB e2e test failure where webhookWorkflow gets 404 instead of 202.