Open
Conversation
Contributor
|
Thanks for the pull request. My main concern is that I want people who are using php < 5.3 to be able to use this library. Correct me if I'm wrong, but I believe that by switching to classmap it will require namespacing |
Author
|
Composer requires php >5.3.2 so it doesn't matter. Just leave in the requires if you want it to be compatible with php < 5.3. |
Author
|
Classmap is used to auto load libraries that do not comply with psr-0, so you don't need to use namespaces. As you can see in my pull request it doesn't add namespaces. |
Contributor
|
Oh ok great I'll do some testing with it and see about getting it merged. Thanks! |
jbwyme
force-pushed
the
master
branch
3 times, most recently
from
d56b9db to
b03cf69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have switched to classmap by changing the composer.json file and removing the now unnecessary requires in Mixpanel.php. I think this works...needs some testing. This was in response to #8