Skip to content

1835 improve rating component #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Lisa18289 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

1835 improve rating component #2078

Lisa18289 wants to merge 12 commits into from

Conversation

@Lisa18289
Copy link
Member

@Lisa18289 Lisa18289 commented Oct 20, 2025

No description provided.

@Lisa18289 Lisa18289 self-assigned this Oct 20, 2025
@Lisa18289 Lisa18289 linked an issue Oct 20, 2025 that may be closed by this pull request
Improve Rating Component #1835
Open
@Lisa18289 Lisa18289 marked this pull request as draft October 20, 2025 09:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 33.65% 8951 / 26593
🔵 Statements 33.65% 8951 / 26593
🔵 Functions 63.74% 640 / 1004
🔵 Branches 82.39% 1198 / 1454
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/Rating/Rating.tsx 17.91% 100% 100% 17.91% 29-90
packages/components/src/components/Rating/components/RatingSegment/RatingSegment.tsx 34.78% 100% 0% 34.78% 16-35
packages/components/src/components/Rating/components/RatingSegment/index.ts 100% 100% 100% 100%
packages/components/src/components/Rating/stories/Default.stories.tsx 0% 100% 100% 0% 2-74
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
packages/components/src/integrations/react-hook-form/components/Field/Field.tsx 89.7% 83.33% 66.66% 89.7% 33-38, 42-47, 74-75
packages/components/src/integrations/react-hook-form/components/Field/stories/Rating.stories.tsx 0% 100% 100% 0% 2-131
Generated in workflow #4045 for commit d5de629 by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 20, 2025 09:46 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 21, 2025 05:43 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 29, 2025 07:35 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 29, 2025 07:43 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 marked this pull request as ready for review November 4, 2025 05:53
@Lisa18289 Lisa18289 enabled auto-merge (squash) November 4, 2025 05:54
@Lisa18289
Merge remote-tracking branch 'origin/main' into 1835-improve-rating-c…
b85d2bb 
…omponent

# Conflicts:
#	packages/components/src/components/propTypes/index.ts
@mfal mfal force-pushed the main branch 3 times, most recently from 691f184 to 11ac921 Compare December 22, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Lisa18289 Lisa18289

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Rating Component

3 participants

@Lisa18289 @mfal