feat: add "--update-context" flag to app installation commands #1543
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "opensearch-host": OptionFlag<string>; | ||
| "opensearch-port": OptionFlag<string>; | ||
| entrypoint: OptionFlag<string | undefined>; | ||
| "update-context": BooleanFlag<boolean | undefined>; |
There was a problem hiding this comment.
The type BooleanFlag<boolean | undefined> is inconsistent with the flag definition where default: undefined is set. Boolean flags should typically use BooleanFlag<boolean> since they resolve to true/false at runtime, or the default should be explicitly set to false rather than undefined.
| "update-context": BooleanFlag<boolean | undefined>; | |
| "update-context": BooleanFlag<boolean>; |
| "update the CLI context to use the newly created app installation", | ||
| char: "c", | ||
| required: false, | ||
| default: undefined, |
There was a problem hiding this comment.
Boolean flags should have default: false instead of default: undefined. Setting default: undefined is unusual for boolean flags and can lead to unexpected behavior when checking the flag value.
| default: undefined, | |
| default: false, |
No description provided.