Skip to content

Prefer Atomic Test UUID over calculated hash for Ability ID #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leba-atr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prefer Atomic Test UUID over calculated hash for Ability ID #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/atomic_svc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ async def _save_ability(self, entries, test):
"""
Return True if an ability was saved.
"""
ability_id = hashlib.md5(json.dumps(test).encode()).hexdigest()
ability_id = test.get('auto_generated_guid') or hashlib.md5(json.dumps(test).encode()).hexdigest()
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The fallback to MD5 hash maintains the old behavior but could lead to inconsistent ID types. Consider documenting the expected format of 'auto_generated_guid' and whether it should be validated before use.

Copilot uses AI. Check for mistakes.

tactics_li = self.technique_to_tactics.get(entries['attack_technique'], ['redcanary-unknown'])
tactic = 'multiple' if len(tactics_li) > 1 else tactics_li[0]
Expand Down