Closed
Conversation
* update smoot-design for new alerts * more smoot bumps * whoopsie-daisy * whooooopsie * remove an unnecessary element * fix a test * pin smoot to a real version
* Switch to v3 for program enrollments * Feedback * Feedback * Fix tests
* Do not use desctructing for build time static replacement * Destructuring is ok in server components, but consistency here should serve as a reminder
* reorganize UnstyledRawHtml, allow some extra tags * require https
* add context menu items to link to product pages * remove titleAction argument as it's not necessary anymore * fix logic surrounding marketing urls and add tests * program title link should go to program dashboard * check include_in_learn_catalog before adding show course details to context menu * remove unnecessary array wrapper * remove unnecessary router usage * card title should perform enrollment when applicable * fix tests after rebase * fix issue with getting legacy product page URL from v3 program enrollment * use readable id to construct legacy program product page url
…peline to create it (#2938)
* fix: change byline author behaviour --------- Co-authored-by: Ahtesham Quraish <ahtesham.quraish@192.168.1.6>
OpenAPI ChangesShow/hide 11 changes: 0 error, 0 warning, 11 infoUnexpected changes? Ensure your branch is up-to-date with |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+226
to
236
| etl_source, | ||
| ) | ||
| redis_cache.delete(cache_key) | ||
| except Exception: | ||
| redis_cache.delete(cache_key) | ||
| log.exception("Failed to trigger ETL for %s", etl_source) | ||
|
|
||
|
|
||
| def sync_edx_archive( | ||
| etl_source, s3_key: str, *, course_id: str | None = None, overwrite: bool = False | ||
| ): |
There was a problem hiding this comment.
Bug: The trigger_resource_etl function lacks a case for ETLSource.oll.name, causing it to silently fail when trying to trigger an ETL for a new OLL course archive.
Severity: HIGH
Suggested Fix
Add an elif block to trigger_resource_etl to handle ETLSource.oll.name by calling the appropriate task, tasks.get_oll_data.apply_async(), similar to how other ETL sources like mit_edx and xpro are handled.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: learning_resources/etl/edx_shared.py#L192-L236
Potential issue: When a webhook for a new OLL course archive is received and no
corresponding run exists, the system calls `trigger_resource_etl` with
`ETLSource.oll.name`. However, this function is missing a handler for OLL. It falls
through to an `else` block which logs a warning "No ETL pipeline for oll, cannot sync
archive" and exits without starting the necessary ETL process. This results in a silent
failure where new OLL course archives are not ingested, contradicting the PR's
objective.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahtesham Quraish
Matt Bertrand
Tobias Macey
Carey P Gumaer
Chris Chudzicki
Jon Kafton
Nathan Levesque