fix(deps): update dependency drf-spectacular to ^0.29.0#2734
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
fix(deps): update dependency drf-spectacular to ^0.29.0#2734renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
1002acb to
b3baeec
Compare
01be626 to
7279d20
Compare
87252cd to
ad804ca
Compare
f3c0f9d to
36de0a9
Compare
| drf-nested-routers = "^0.95.0" | ||
| drf-spectacular = "^0.28.0" | ||
| drf-spectacular = "^0.29.0" | ||
| feedparser = "^6.0.10" |
There was a problem hiding this comment.
Bug: The custom CustomDjangoFilterExtension uses fragile positional argument access (args[4]) in resolve_filter_field, which will likely break due to refactoring in drf-spectacular 0.29.0.
Severity: HIGH
Suggested Fix
Refactor the resolve_filter_field method in main/schema.py to use keyword arguments instead of positional arguments. Inspect the method signature in drf-spectacular 0.29.0 to identify the correct parameter names and update the implementation to access them safely, removing the dependency on argument order.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L52
Potential issue: The `CustomDjangoFilterExtension` in `main/schema.py` overrides the
`resolve_filter_field` method and accesses the fifth positional argument via `args[4]`.
This implementation assumes a fixed method signature. The `drf-spectacular` 0.29.0
release notes state that the django-filter extension was significantly refactored. If
the signature of `resolve_filter_field` has changed in the new version, accessing
`args[4]` could lead to an `IndexError` or incorrect behavior during OpenAPI schema
generation. This would cause a runtime failure when the API schema is accessed.
Did we get this right? 👍 / 👎 to inform future reviews.
1a78637 to
6a781a8
Compare
6a781a8 to
257f828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.28.0→^0.29.0Release Notes
tfranzel/drf-spectacular (drf-spectacular)
v0.29.0Compare Source
#​1466 <https://github.com/tfranzel/drf-spectacular/issues/1466>_#​1392 <https://github.com/tfranzel/drf-spectacular/issues/1392>_#​1450 <https://github.com/tfranzel/drf-spectacular/issues/1450>_) [Enric Pou]#​1432 <https://github.com/tfranzel/drf-spectacular/issues/1432>_) [Chris Wesseling]#​1432 <https://github.com/tfranzel/drf-spectacular/issues/1432>_#​1463 <https://github.com/tfranzel/drf-spectacular/issues/1463>_OpenApiViewExtensionnot providing view instance underself.target(#​1405 <https://github.com/tfranzel/drf-spectacular/issues/1405>_) [astro-stan]#​1436 <https://github.com/tfranzel/drf-spectacular/issues/1436>_#​1461 <https://github.com/tfranzel/drf-spectacular/issues/1461>_#​1459 <https://github.com/tfranzel/drf-spectacular/issues/1459>_#​1435 <https://github.com/tfranzel/drf-spectacular/issues/1435>_)#​1444 <https://github.com/tfranzel/drf-spectacular/issues/1444>_)#​1401 <https://github.com/tfranzel/drf-spectacular/issues/1401>_#​1389 <https://github.com/tfranzel/drf-spectacular/issues/1389>_) [Mike Manger]#​1354 <https://github.com/tfranzel/drf-spectacular/issues/1354>_Breaking changes / important additions:
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.