Allow optional custom salt#25
Open
millar wants to merge 1 commit intomitchellvanw:masterfrom
millar:patch-1
Open
Allow optional custom salt#25millar wants to merge 1 commit intomitchellvanw:masterfrom millar:patch-1
millar wants to merge 1 commit intomitchellvanw:masterfrom
millar:patch-1
Conversation
Because I'm using this package in conjunction with the JS version, on the client side, I need to have matching salts but don't wish to expose my app's secret key to the world. This will now look for a package config specific salt before falling back to the app key. Also mentioned in #21.
|
@mitchellvanw could you merge this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I'm using this package in conjunction with the JS version, on the client side, I need to have matching salts but don't wish to expose my app's secret key to the world. This will now look for a package config specific salt before falling back to the app key.
Also mentioned in #21.