This repository was archived by the owner on Oct 31, 2023. It is now read-only.
config: correct doc comment and add complex test#21
Open
johanbrandhorst wants to merge 1 commit intomitchellh:masterfrom
Open
config: correct doc comment and add complex test#21johanbrandhorst wants to merge 1 commit intomitchellh:masterfrom
johanbrandhorst wants to merge 1 commit intomitchellh:masterfrom
Conversation
As a user unfamiliar with HCL, it was not clear how to define an "object". I looked at the test and couldn't find anything testing this functionality, and I also found inconsistent comments around the use of regular expressions in the translation. This commit adds a complex test example and corrects the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user unfamiliar with HCL, it was not clear how to define
an "object". I looked at the test and couldn't find anything testing
this functionality, and I also found inconsistent comments around
the use of regular expressions in the translation.
This commit adds a complex test example and corrects the comments.