This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Update go-license-detector to v3#20
Open
johanbrandhorst wants to merge 1 commit intomitchellh:masterfrom
Open
Conversation
go-license-detector v2 was depending on an old version of gopkg.in/src-d/go-git, and unfortunately the latest version broke compatibility unexpectedly. This made golicense unnecessarily difficult to build in repositories which otherwise used gopkg.in/src-d/go-git. Upgrading to v3 removes these problems. See src-d/go-git#1262 for full context. It also allows us to remove a whole lot of packages from go.mod in general.
96d9c2a to
f78e380
Compare
|
For anyone looking how to use this fixed version in go1.16 or later, I got the following to work: The following by itself doesn't work: The error is reproducible by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-license-detector v2 was depending on an old version of
gopkg.in/src-d/go-git, and unfortunately the latest version
broke compatibility unexpectedly. This made golicense
unnecessarily difficult to build in repositories which otherwise
used gopkg.in/src-d/go-git. Upgrading to v3 removes these problems.
See src-d/go-git#1262 for full context.
It also allows us to remove a whole lot of packages from go.mod
in general.