This repository was archived by the owner on Jul 14, 2021. It is now read-only.
add --allow-external and process requirements.local last#9
Open
miraculixx wants to merge 2 commits intomasterfrom
Open
add --allow-external and process requirements.local last#9miraculixx wants to merge 2 commits intomasterfrom
miraculixx wants to merge 2 commits intomasterfrom
Conversation
this makes --process-dependency-links work
Owner
Author
|
@gaumire please review - any red flags with these changes? thx. |
Collaborator
|
looks good, hoping you've tested it. |
Collaborator
|
@miraculixx would like to request to also remove these lines in this PR. Duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--allow-external,--process-dependency-linkswouldn't find github-hosted packagesrequirements.localorrequirements.local.$APP*) Rationale: e.g. a package in requirements.local requests "abc>=1.0.3" and fetches
abc==2.0, however requirements.extra specifiesabc==1.2, at the time requirements.extra is processed it would ignoreabc==1.2. a similar case ensues when requirements.local requests a package that itself does not know to fetch in the particular version it requests, e.g. because the dependency link is wrong, where however a requirements.extra installation is provided