Skip to content

Read CIFS encryption key from environment variable and base64 decode it #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −5
Draft

Read CIFS encryption key from environment variable and base64 decode it #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5055db
Initial plan
Copilot Oct 23, 2025
f3a331b
Implement CIFS encryption key reading from environment variable with …
Copilot Oct 23, 2025
04f7cf8
Address code review: use specific exceptions and ascii encoding
Copilot Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions MAIA/maia_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import asyncio
import base64
import binascii
import json
import os
import subprocess
Expand Down Expand Up @@ -429,15 +430,29 @@ def create_maia_namespace_values(namespace_config, cluster_config, config_folder
if mlflow_configs:
maia_namespace_values["mlflow"] = {
"enabled": True,
#"user": base64.b64decode(mlflow_configs["mlflow_user"]).decode("ascii"),
# "user": base64.b64decode(mlflow_configs["mlflow_user"]).decode("ascii"),
"user": mlflow_configs["mlflow_user"],
"password": mlflow_configs["mlflow_password"]
#"password": base64.b64decode(mlflow_configs["mlflow_password"]).decode("ascii"),
"password": mlflow_configs["mlflow_password"],
# "password": base64.b64decode(mlflow_configs["mlflow_password"]).decode("ascii"),
}

enable_cifs = namespace_config.get("extra_configs", {}).get("enable_cifs", False)
if enable_cifs:
maia_namespace_values["cifs"] = {"enabled": True, "encryption": {"publicKey": ""}} # base64 encoded}
# Read and decode CIFS encryption key from environment variable
cifs_encryption_key_b64 = os.environ.get("CIFS_ENCRYPTION_KEY", "")
public_key = ""

if cifs_encryption_key_b64:
try:
public_key = base64.b64decode(cifs_encryption_key_b64).decode("ascii")
except (binascii.Error, UnicodeDecodeError) as e:
print(f"⚠️ Warning: Failed to decode CIFS_ENCRYPTION_KEY: {e}")
print(" Using empty public key as fallback.")
else:
print("⚠️ Warning: CIFS_ENCRYPTION_KEY environment variable is not set.")
print(" Using empty public key as fallback.")

maia_namespace_values["cifs"] = {"enabled": True, "encryption": {"publicKey": public_key}}
namespace_id = namespace_config["group_ID"].lower().replace("_", "-")
Path(config_folder).joinpath(namespace_config["group_ID"], "maia_namespace_values").mkdir(parents=True, exist_ok=True)
with open(
Expand Down Expand Up @@ -1253,7 +1268,7 @@ def create_maia_dashboard_values(config_folder, project_id, cluster_config_dict,

if "discord_url" in maia_config_dict:
maia_dashboard_values["dashboard"]["discord_url"] = maia_config_dict["discord_url"]
#if "discord_signup_url" in maia_config_dict:
# if "discord_signup_url" in maia_config_dict:
# maia_dashboard_values["dashboard"]["discord_signup_url"] = maia_config_dict["discord_signup_url"]
if "discord_support_url" in maia_config_dict:
maia_dashboard_values["dashboard"]["discord_support_url"] = maia_config_dict["discord_support_url"]
Expand Down